Improved default values in Edit New File and View File dialogs
ClosedPublic

Authored by nmel on Jun 22 2018, 7:26 AM.

Details

Summary

Use current file name as a selected default in the dialogs.
This is a Total Commander behavior and it's proved to be useful.

FIXED: [ 282069 ] New text file dialog - do not show path (needs rephrasing)
BUG: 282069

Test Plan

Check Shift+F4, Shift+F3, popup menu (Create New...), coping and unpacking files and maybe other operations that involve KChooseDir.
I could not find any case where FileSystem::ensureTrailingSlash is actually needed.

Diff Detail

Repository
R167 Krusader
Branch
edit-new-file-default
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 219
Build 219: arc lint + arc unit
nmel requested review of this revision.Jun 22 2018, 7:26 AM
nmel created this revision.
nmel added a reviewer: asensi.

This thing bugs me for a while, and now I finally have a chance to fix it. I think it's a regression from previous versions because I remember my frustration when it was introduced. According to the related bug, it should be before v2.4.0-beta1, but I don't have any really old versions installed. Toni, you mentioned an old VM with an old Krusader on it — can you check, please?

To all: Please let me know if you have any usability concerns.

asensi accepted this revision as: asensi.Jun 22 2018, 10:32 AM

Toni, you mentioned an old VM with an old Krusader on it — can you check, please?

In that old virtual machine, Krusader 1.90.0 shows the same behavior when pressing Shift+F3 or Shift+F4 (current file name is not the selected default in the dialogs).

To all: Please let me know if you have any usability concerns.

I think that those changes improved the situation :-) . Using Kubuntu 18.04: my performed tests went alright. Other people can do their checks. Thanks, Nikita!

Note: I have created two bug reports about F3 and Shift+F3, but because of some problems that already existed:

This revision is now accepted and ready to land.Jun 22 2018, 10:32 AM
nmel added a comment.Jun 28 2018, 6:43 AM

Toni, thanks for checking and testing.

For Shift+F3, I confirmed the bugs. Thanks for taking time to log the issues!

This revision was automatically updated to reflect the committed changes.