Differential D13666

replace pot with po only for file extension when generating language x-test
ClosedPublic
Actions

Authored by lueck on Jun 21 2018, 7:12 PM.

Details

Reviewers
ltoscano
Group Reviewers
Localization
Commits
R883:1523039: replace pot with po only for file extension when generating language x-test
Summary

https://logs.l10n.kde.org/180621.branches_stable_l10n-kf5-plasma-lts reads:

Warning: language x-test contains POT files!
x-test/messages/kde-workspace/plasma_wallpaper_org.kde.pod.pot

add char $ to regexp to replace only "pot" when this is a file extension, i.e at the end of the filename string

patch should be applied to all branches tracked by scripty

Test Plan

echo "plasma_wallpaper_org.kde.potd.pot" | sed -e "s/\.pot/.po/"
plasma_wallpaper_org.kde.pod.pot
-> wrong filename with extension .pot

echo "plasma_wallpaper_org.kde.potd.pot" | sed -e "s/\.pot$/.po/"
plasma_wallpaper_org.kde.potd.po
-> correct filename with extension .po

Diff Detail

Repository
R883 Subversion
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
lueck requested review of this revision.Jun 21 2018, 7:12 PM
lueck created this revision.
ltoscano accepted this revision as: ltoscano.Jun 21 2018, 7:31 PM
ltoscano added a subscriber: ltoscano.

It makes sense, thanks.

This revision is now accepted and ready to land.Jun 21 2018, 7:31 PM
Closed by commit R883:1523039: replace pot with po only for file extension when generating language x-test (authored by lueck, committed by ). · Explain WhyAug 21 2018, 8:45 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 40123

View Options

branches/stable/l10n-kf5-plasma-lts/x-test/internal/update_xx.sh

Loading...