Random improvements, commit just for review
ClosedPublic

Authored by kossebau on Jun 21 2018, 3:43 PM.

Details

Reviewers
heikobecker
Summary

Some more changes, which are rather opinionated, so best decided about by
maintainer :)

  • bump min cmake version to 3.0 (2.* is really old, 3.0 standard across kde)
  • use cmake VERSION feature now 3.0 is used
  • define min deps of Qt5 & KF5 Qt 5.7 by QT_DISABLE_DEPRECATED_BEFORE KF5 5.18 rather random, no idea what a sane base is or what code relies on
  • drop unneeded include(FindGettext)
  • set CMAKE_MODULE_PATH completly in single place
  • use GenericName entry instead of Comment in desktop filename entry seems used in todays app menus, e.g. openSUSE patches in this entry
  • add FileTools as another category (picked from xdg menu-spec)

Please tell which ones you do not like or would like differently, would then
do anything okayed in own commits to master.

Diff Detail

Repository
R758 KRename: Bulk File Renaming
Branch
generalpimping
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 208
Build 208: arc lint + arc unit
kossebau requested review of this revision.Jun 21 2018, 3:43 PM
kossebau created this revision.
heikobecker accepted this revision.Jun 21 2018, 7:11 PM

All changes look fine to me.

Not sure if the comment is displayed as a tooltip in any launcher like the spec says. At least none of Plasma's launchers display it. Otherwise it possibly would've been worth keeping it with a more elaborate text, something like "Can easily rename a huge number of files in one go".

This revision is now accepted and ready to land.Jun 21 2018, 7:11 PM
kossebau closed this revision.Jun 21 2018, 9:18 PM

All changes look fine to me.

Okay, thanks for the review, committed as 66d2e36a5c1bbf68504b8b4166edf5cb79ad5bf4 to 06a82b7371e3e03500e9c72baeff0c0207c30d4f

Not sure if the comment is displayed as a tooltip in any launcher like the spec says. At least none of Plasma's launchers display it. Otherwise it possibly would've been worth keeping it with a more elaborate text, something like "Can easily rename a huge number of files in one go".

I also had no good idea for a text for the comment to propose, so did not add something new in the patch as non-redundant-with-name-or-genericname comment text as asked by the spec. Many desktop files I checked do not have a comment, so might not be that critical indeed. Will have a look-out for the near future if any comment is shown somewhere.