Remove duplicated auto backend resolution
ClosedPublic

Authored by davidedmundson on Jun 21 2018, 2:46 PM.

Details

Summary

kwin_wayland now automatically chooses an appropriate backend, such as
DRM, nested wayland or nested X. If nested it will automatically go into
windowed mode regardless of whether --windowed is set and works fine.

Backend choosing logic existed duplicated in older code for kwin_wayland
--windowed, with the subtle unexpected difference that it preferred
running as an X client over running as a wayland cient if both are
present. This simplifies codes and syncs automatic resolution behaviour.

kwin_wayland --windowed with --x11-display or --wayland-display will
remain the same.

Test Plan

Ran kwin_wayland with and without --windowed inside another wayland.
Got the same backend chosen
Tested that kwin_wayland (without --windowed) on an X machine worked just fine.

Diff Detail

Repository
R108 KWin
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 202
Build 202: arc lint + arc unit
davidedmundson created this revision.Jun 21 2018, 2:46 PM
Restricted Application added a project: KWin. · View Herald TranscriptJun 21 2018, 2:46 PM
Restricted Application added a subscriber: kwin. · View Herald Transcript
davidedmundson requested review of this revision.Jun 21 2018, 2:46 PM

Maybe I should take this further and just remove the windowed flag completely.

mart accepted this revision.Jun 22 2018, 8:41 AM
mart added a subscriber: mart.

Maybe I should take this further and just remove the windowed flag completely.

+1

This revision is now accepted and ready to land.Jun 22 2018, 8:41 AM

Remove windowed

This revision was automatically updated to reflect the committed changes.