Differential D13623

[kded kcm] Fix estimating dbusModuleName of kded plugins
ClosedPublic
Actions

Authored by kossebau on Jun 19 2018, 9:42 PM.

Details

Reviewers
dfaure
davidedmundson
Commits
R119:6f491642e9b9: [kded kcm] Fix estimating dbusModuleName of kded plugins
Summary

The entry X-KDE-DBus-ModuleName has never been used by kded code,
at least is not using it these days, so the check for that metadata entry
and using its value is broken.

Instead Kded::loadModule() used KPluginMetaData::pluginId() to set the
module name, which then is used by KDEDModule for its D-Bus object path.

The branch for handling an empty name is removed as that fallback is
covered by KPluginMetaData already.

Test Plan

KCM now lists all kded plugins, no longer complains about modules it could not
relate.

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
kossebau created this revision.Jun 19 2018, 9:42 PM
Restricted Application added a project: Plasma. · View Herald TranscriptJun 19 2018, 9:42 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
kossebau requested review of this revision.Jun 19 2018, 9:42 PM
kossebau added a comment.Jun 19 2018, 9:42 PM

Target: 5.12 LTS

kossebau edited the summary of this revision. (Show Details)Jun 19 2018, 9:42 PM
dfaure accepted this revision.Jun 19 2018, 9:45 PM
This revision is now accepted and ready to land.Jun 19 2018, 9:45 PM
Closed by commit R119:6f491642e9b9: [kded kcm] Fix estimating dbusModuleName of kded plugins (authored by kossebau). · Explain WhyJun 19 2018, 10:31 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mkcms/kded/kcmkded.cpp (18 lines)

Diff 36362

View Options

kcms/kded/kcmkded.cpp

Loading...