Remove unused entry X-KDE-DBus-ModuleName from kded plugins' metadata
ClosedPublic
Actions

Authored by kossebau on Jun 19 2018, 9:12 PM.

Details

Reviewers

Commits

Summary

That entry has never been used, instead the plugin id (as by
KPluginMetaData::pluginId()) has been used for the module name in the
D-Bus object path.

Repository

R241 KIO

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript

kossebau requested review of this revision.Jun 19 2018, 9:12 PM

Note: kcoreaddons, baloo, kservice/autotests, and kdelibs4support mention this key too, you can clean it all up ;)

Thanks!

This revision is now accepted and ready to land.Jun 19 2018, 9:19 PM

This revision was automatically updated to reflect the committed changes.

In D13622#280325, @dfaure wrote:

Note: kcoreaddons, baloo, kservice/autotests, and kdelibs4support mention this key too, you can clean it all up ;)

Done. Thanks for quick review :)

			Path	Packages
M			src/ioslaves/http/kcookiejar/kcookiejar.json (1 line)
M			src/ioslaves/remote/kdedmodule/remotedirnotify.desktop (1 line)
M			src/kioexec/kioexecd.json (1 line)
M			src/kpac/proxyscout.json (1 line)
M			src/kpasswdserver/kpasswdserver.json (1 line)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	36356	bba871d		Jun 19 2018, 9:12 PM	★	★
Diff 2	36359	bba871d	R241:486c4e86c8d38cee49e6b1feb5e6bf7e191513cd	Jun 19 2018, 9:49 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
9fa87ca2f199	a55d2efb853e	bba871deced2	Friedrich W. H. Kossebau	Remove unused entry X-KDE-DBus-ModuleName from kded plugins' metadata (Show More…)	Jun 19 2018, 9:11 PM