Differential D13611

[Fonts KCM] disable "to" label when its companion controls are also disabled
ClosedPublic
Actions

Authored by ngraham on Jun 19 2018, 2:00 PM.

Details

Reviewers
davidedmundson
Group Reviewers
VDG
Commits
R119:27acf95acf61: [Fonts KCM] disable "to" label when its companion controls are also disabled
R119:ac5c22153aea: Merge branch 'Plasma/5.13'
Summary

Title and screenshots say it all.

Test Plan

Before:

After:

Diff Detail

Repository
R119 Plasma Desktop
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 124
Build 124: arc lint + arc unit
ngraham created this revision.Jun 19 2018, 2:00 PM
Restricted Application added a project: Plasma. · View Herald TranscriptJun 19 2018, 2:00 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ngraham requested review of this revision.Jun 19 2018, 2:00 PM
ngraham edited the test plan for this revision. (Show Details)Jun 19 2018, 2:01 PM
davidedmundson accepted this revision.Jun 19 2018, 2:01 PM
This revision is now accepted and ready to land.Jun 19 2018, 2:01 PM
Closed by commit R119:27acf95acf61: [Fonts KCM] disable "to" label when its companion controls are also disabled (authored by ngraham). · Explain WhyJun 19 2018, 2:08 PM
This revision was automatically updated to reflect the committed changes.
broulik added a subscriber: broulik.Jun 27 2018, 9:40 AM
broulik added inline comments.
kcms/fonts/package/contents/ui/main.qml
103

Also could have been done here, since enabled propagates recursively

Revision Contents
Changeset List

Diff 36336

View Options

kcms/fonts/package/contents/ui/main.qml

Loading...