Set correct DPR on wayland cursors received from remote buffers
ClosedPublic

Authored by davidedmundson on Jun 19 2018, 12:53 PM.

Details

Summary

It will then be renderered appropriately when painting to the output
buffer.

Test Plan

Updated unit test, plus used with other relevant patches

Diff Detail

Repository
R108 KWin
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 116
Build 116: arc lint + arc unit
Restricted Application added a project: KWin. · View Herald TranscriptJun 19 2018, 12:53 PM
Restricted Application added a subscriber: kwin. · View Herald Transcript
davidedmundson requested review of this revision.Jun 19 2018, 12:53 PM

To clarify the ineviatable question of what's needed:

  • DRM: needs updating (see patch)
  • Software cursor + QPainter: doesn't need any changes, it should "just work" as everything is using QPainter properly.
  • Software cursor + GL: needs a change, but for me it's super broke and I need to fix that before starting adding to it.
  • Wayland backend: If we were a normal client we would just set the buffer scale to match our cursor buffer scale, but I'm not sure what we want.

Right now kwin_wayland --windowed --scale 2 inside a compositor that's also at 2x renders everything bigger than the host. It is technically "wrong", but frankly far more helpful for me debugging.

  • X11 backend: Needs changes. Involves having to log into X. So will delay for as long as possible.
graesslin accepted this revision.Jun 23 2018, 7:52 AM
This revision is now accepted and ready to land.Jun 23 2018, 7:52 AM
This revision was automatically updated to reflect the committed changes.