Differential D13597

Use a correct emblem icon for readonly files and folders
ClosedPublic
Actions

Authored by ngraham on Jun 19 2018, 5:14 AM.

Details

Reviewers
broulik
Group Reviewers
Dolphin
Frameworks
Commits
R241:0726f17ae791: Use a correct emblem icon for readonly files and folders
Summary

BUG: 360980
FIXED-IN: 5.48

Test Plan

Browsed some read-only files and folders with Dolphin. No visual change with Breeze or Oxygen icons. Didn't test other themes, but according to the bug report, this should fix an issue for them.

Diff Detail

Repository
R241 KIO
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ngraham created this revision.Jun 19 2018, 5:14 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptJun 19 2018, 5:14 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
ngraham requested review of this revision.Jun 19 2018, 5:14 AM
broulik accepted this revision.Jun 27 2018, 9:41 AM
broulik added a subscriber: broulik.

Neither icon is in the naming specification but since this is meant as an overlay, emblem makes more sense.

This revision is now accepted and ready to land.Jun 27 2018, 9:41 AM
Closed by commit R241:0726f17ae791: Use a correct emblem icon for readonly files and folders (authored by ngraham). · Explain WhyJun 27 2018, 1:01 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/core/kfileitem.cpp (2 lines)

Diff 36761

View Options

src/core/kfileitem.cpp

Loading...