Move General settings to the top
ClosedPublic

Authored by ngraham on Jun 18 2018, 11:27 PM.

Details

Summary

KDE apps generally (ha ha) have their General page at the top of the list, so it's the first thing the user sees when they open the Settings window, but Dolphin is an exception. It puts the General page last! This patch makes Dolphin consistent with other KDE apps by moving the General page up to the top.

Test Plan

Diff Detail

Repository
R318 Dolphin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ngraham created this revision.Jun 18 2018, 11:27 PM
Restricted Application added a project: Dolphin. · View Herald TranscriptJun 18 2018, 11:27 PM
Restricted Application added a subscriber: kfm-devel. · View Herald Transcript
ngraham requested review of this revision.Jun 18 2018, 11:27 PM
ngraham edited the test plan for this revision. (Show Details)Jun 18 2018, 11:27 PM
ngraham added a reviewer: KDE Applications.
elvisangelaccio added a subscriber: elvisangelaccio.

Indeed, it probably makes sense to be consistent here.

This revision is now accepted and ready to land.Jun 19 2018, 8:49 PM

Does this require a documentation change too (doc/)?

@ltoscano Yes, seems the docboock lists the page in their actual order within the dialog.

Maybe the patch can be applied in this same change, so we don't forget.

ngraham planned changes to this revision.Jun 19 2018, 9:19 PM

Sure, I'll make the doc change too.

ngraham updated this revision to Diff 36366.Jun 19 2018, 10:56 PM

Also move the General section to the top in the docbook, to match the UI change

This revision is now accepted and ready to land.Jun 19 2018, 10:56 PM
Restricted Application added a project: Documentation. · View Herald TranscriptJun 19 2018, 10:56 PM
Restricted Application added a subscriber: kde-doc-english. · View Herald Transcript

All good now?

ltoscano accepted this revision as: ltoscano.Jun 19 2018, 11:02 PM

Oh, well, the cpp part did not change, so let's consider the previous approval as still valid. Approving the documentation change.

This revision was automatically updated to reflect the committed changes.