Differential D13590

Use QUrl < instead of QString.compare
ClosedPublic
Actions

Authored by jtamate on Jun 18 2018, 3:43 PM.

Details

Reviewers
dfaure
Group Reviewers
Frameworks
Commits
R241:bba871deced2: Use QUrl < instead of QString.compare
Summary

Remove the lessThan method.
std::sort will use QUrl < operator (since Qt 5.4).

Diff Detail

Repository
R241 KIO
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
jtamate created this revision.Jun 18 2018, 3:43 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptJun 18 2018, 3:43 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
jtamate requested review of this revision.Jun 18 2018, 3:43 PM
dfaure requested changes to this revision.Jun 18 2018, 4:14 PM

Well then you can just remove lessThan altogether, and call std::sort with only 2 arguments instead of 3 ;)

This revision now requires changes to proceed.Jun 18 2018, 4:14 PM
jtamate updated this revision to Diff 36283.Jun 18 2018, 4:45 PM
jtamate edited the summary of this revision. (Show Details)

You're right :-)

dfaure accepted this revision.Jun 18 2018, 6:49 PM
This revision is now accepted and ready to land.Jun 18 2018, 6:49 PM
Closed by commit R241:bba871deced2: Use QUrl < instead of QString.compare (authored by jtamate). · Explain WhyJun 19 2018, 2:54 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/widgets/kdirmodel.cpp (7 lines)

Diff 36343

View Options

src/widgets/kdirmodel.cpp

Loading...