Panel: Always delete files by their URL

Authored by abika on Jun 16 2018, 5:06 PM.



Virtual files could not be deleted because the argument for the delete
operation was the (real) filenames but the filename of a virtual file is
the path to the real file. This is fixed.

FIXED: [ 394896 ] Files fed to listbox (and all other files in virt://) cannot be deleted
BUG: 394896

Test Plan
  • tested deletion (real deletion & move to trash) of virtual files
  • tested deletion (real deletion & move to trash) of normal (file://) files and directories

Diff Detail

R167 Krusader
No Linters Available
No Unit Test Coverage
Build Status
Buildable 65
Build 65: arc lint + arc unit
abika requested review of this revision.Jun 16 2018, 5:06 PM
abika created this revision.
yurchor accepted this revision as: yurchor.Jun 16 2018, 5:21 PM
yurchor added a subscriber: yurchor.

Tested to work as expected. Thanks.

This revision is now accepted and ready to land.Jun 16 2018, 5:21 PM
asensi accepted this revision as: asensi.Jun 17 2018, 1:48 PM
asensi added a subscriber: asensi.

Note: The tag "Krusader" was added to the present differential revision so that it's seen now at least in and , and consequently more people may review this proposal.

For my part, my performed tests (using Kubuntu 18.04) went also Ok! Thanks, Alex!

nmel accepted this revision.Jul 8 2018, 6:41 AM
nmel added a subscriber: nmel.

Reviewed and tested - works nicely!
Please push this.

abika closed this revision.Jul 8 2018, 7:35 PM

Took some time but now its in master.

Thanks for testing everybody.