Differential D13568

SinkModel: Ignore virtual sinks for preferredSink
ClosedPublic
Actions

Authored by drosca on Jun 16 2018, 10:58 AM.

Details

Reviewers
mart
Group Reviewers
Plasma
Commits
R115:974bd408f719: SinkModel: Ignore virtual sinks for preferredSink
Summary

Preferred sink is used for volume control with media keys,
so it should be controlling real hardware volume instead of
virtual devices.

BUG: 395466
FIXED-IN: 5.13.1

Test Plan

Builds

Diff Detail

Repository
R115 Plasma Audio Volume Applet
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
drosca created this revision.Jun 16 2018, 10:58 AM
Restricted Application added a project: Plasma. · View Herald TranscriptJun 16 2018, 10:58 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
drosca requested review of this revision.Jun 16 2018, 10:58 AM
mart accepted this revision.Jun 22 2018, 9:09 AM
This revision is now accepted and ready to land.Jun 22 2018, 9:09 AM
Closed by commit R115:974bd408f719: SinkModel: Ignore virtual sinks for preferredSink (authored by drosca). · Explain WhyJun 26 2018, 9:17 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/device.h (10 lines)
Msrc/device.cpp (5 lines)
Msrc/pulseaudio.cpp (2 lines)

Diff 36672

View Options

src/device.h

Loading...
View Options

src/device.cpp

Loading...
View Options

src/pulseaudio.cpp

Loading...