Expression syntax improvements
ClosedPublic

Authored by pprkut on Jun 14 2018, 7:18 PM.

Details

Reviewers
None
Group Reviewers
KDevelop
Commits
R52:dedb6db30ce7: Fix chained print expressions.
Summary
  • Disallow some illegal expressions.
  • Fix chained print expressions.

This causes 10 first/follow conflicts, where I'm not sure how
to solve them or if that would even be feasible to do. Example:

<? print 1 || print 2 || print 3; ?>

php-parser handles this correctly, but conceptually it wouldn't
know if the second || belongs to the first booleanOrExpression or
is a new booleanOrExpression below the assignmentExpression of the
second print.

Diff Detail

Repository
R52 KDevelop: PHP Support
Branch
expressions
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 25
Build 25: arc lint + arc unit
pprkut created this revision.Jun 14 2018, 7:18 PM
Restricted Application added a project: KDevelop. · View Herald TranscriptJun 14 2018, 7:18 PM
Restricted Application added a subscriber: kdevelop-devel. · View Herald Transcript
pprkut requested review of this revision.Jun 14 2018, 7:18 PM
pprkut added inline comments.Jun 14 2018, 7:27 PM
parser/php.g
355–357

stray code from a previous revision :/
already removed that locally

If there's no objections, I'm gonna merge this on Monday together with D13580

This revision was not accepted when it landed; it landed in state Needs Review.Aug 13 2018, 11:56 AM
This revision was automatically updated to reflect the committed changes.