Even though the Slide effect has a KCM, it's not possible to configure
it [slide effect] from the virtual desktops KCM.
This change addresses the problem above.
Before
After
BUG: 395377
davidedmundson |
KWin |
Even though the Slide effect has a KCM, it's not possible to configure
it [slide effect] from the virtual desktops KCM.
This change addresses the problem above.
BUG: 395377
Automatic diff as part of commit; lint not applicable. |
Automatic diff as part of commit; unit tests not applicable. |
kcmkwin/kwindesktop/main.cpp | ||
---|---|---|
526 | can you add Q_FALLTHROUGH when pushing |
kcmkwin/kwindesktop/main.cpp | ||
---|---|---|
526 | Why? |
kcmkwin/kwindesktop/main.cpp | ||
---|---|---|
526 | Tells both the next person and the compiler that you're deliberately treating 1 and 2 the same and haven't just forgotten to return. Otherwise you get something like: Exact situations of what warns are compiler warns about are currently ambiguous and changing, so this might not currently, but it certainly won't do any harm. |
kcmkwin/kwindesktop/main.cpp | ||
---|---|---|
526 | No, I know what Q_FALLTHROUGH is. I don't understand why we need it here. I thought that's totally fine to have such kind of fall through: case 1: case 2: case 42: return; Am I wrong? |
kcmkwin/kwindesktop/main.cpp | ||
---|---|---|
526 | OK, I've re-read your last sentence. I don't think clang or gcc would produce warnings for such kind of fall though. It's worth to mention that LLVM use "case 1: case 2:" quite often. |
kcmkwin/kwindesktop/main.cpp | ||
---|---|---|
526 | I'm aware they don't currently, I still think it's nicer form, but I also really don't care that much. Push whichever you prefer. |