Treat scrollbar as overlay
ClosedPublic

Authored by tcanabrava on Jun 14 2018, 4:27 PM.

Details

Summary

This enables text below scrollbar.

Test Plan

The new trial:

The current Master:

Diff Detail

Repository
R319 Konsole
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
tcanabrava created this revision.Jun 14 2018, 4:27 PM
Restricted Application added a project: Konsole. · View Herald TranscriptJun 14 2018, 4:27 PM
Restricted Application added a subscriber: konsole-devel. · View Herald Transcript
tcanabrava requested review of this revision.Jun 14 2018, 4:27 PM
tcanabrava retitled this revision from Treat scrollBar as overlay This enables text below scroolbar. to Treat scrollBar as overlay.Jun 14 2018, 4:31 PM
tcanabrava edited the summary of this revision. (Show Details)
tcanabrava edited the test plan for this revision. (Show Details)
tcanabrava added reviewers: Konsole, hindenburg.

+1 from me too. This will make it possible for us to have the scrollbar hide itself entirely when the view isn't scrollable, which was previously rejected on the grounds that the scrollbar gutter would still be visible: D11843: Show the scrollbar only when needed

Fuchs added a subscriber: Fuchs.Jun 14 2018, 4:48 PM

I think it makes it a lot harder to see though, depending on what the background is.

This might especially be a pain in TUI applications (powertop, htop etc.) that don't tend to have a lot of whitespace.

Wouldn't the scrollbar disappear entirely for such apps?

powertop.

As you can see, there's a small line in the right but I don't think that it makes life harder at all.
There's also https://phabricator.kde.org/D11843 that would hide scrollbar when uneeded, so that in combination with this makes the issue moot.

Can you share a screenshot showing how it looks with various other terminal color schemes that we ship with? We wouldn't want this change to make the scrollbar virtually invisible.

- Solarized
- Black / White

Thanks! And as previously mentioned, for those cases of full-screen CLI apps, D11843 will make the scrollbar disappear entirely. I like it!

hindenburg retitled this revision from Treat scrollBar as overlay to Treat scrollbar as overlay.Jun 15 2018, 12:54 AM
hindenburg edited the summary of this revision. (Show Details)
hindenburg accepted this revision.Jun 15 2018, 1:05 AM
This revision is now accepted and ready to land.Jun 15 2018, 1:05 AM
This revision was automatically updated to reflect the committed changes.
cfeck added a subscriber: cfeck.Jun 15 2018, 2:05 AM

Since this isn't configurable, has it been tested with different widget styles (Oxygen, Fusion)?

"Ouch", I just did and it doesn't work at all using Oxygen, Fusion or *anything* that has a non - translucent background.
Perhaps I could fix that by forcing a theme on the scrollbar. thinkering.

Since this isn't configurable, has it been tested with different widget styles (Oxygen, Fusion)?

A possible fix:
https://phabricator.kde.org/D13557