Differential D13538

Simplify: Use locals instead of pointers
ClosedPublic
Actions

Authored by tcanabrava on Jun 14 2018, 1:30 PM.

Details

Reviewers
hindenburg
Group Reviewers
Konsole
Commits
R319:7c1fd8d71fab: Simplify: Use locals instead of pointers
Summary

If anything throwed we would have a memleak,
this is smaller and safer.

Diff Detail

Repository
R319 Konsole
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
tcanabrava created this revision.Jun 14 2018, 1:30 PM
Restricted Application added a project: Konsole. · View Herald TranscriptJun 14 2018, 1:30 PM
Restricted Application added a subscriber: konsole-devel. · View Herald Transcript
tcanabrava requested review of this revision.Jun 14 2018, 1:30 PM
hindenburg accepted this revision.Jun 15 2018, 12:46 AM
This revision is now accepted and ready to land.Jun 15 2018, 12:46 AM
Closed by commit R319:7c1fd8d71fab: Simplify: Use locals instead of pointers (authored by tcanabrava, committed by hindenburg). · Explain WhyJun 15 2018, 12:46 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/ProfileManager.cpp (24 lines)

Diff 36183

View Options

src/ProfileManager.cpp

Loading...