Differential D13537

Fix definesandincludes test.
ClosedPublic
Actions

Authored by arrowd on Jun 14 2018, 12:52 PM.

Details

Reviewers
skalinichev
mwolff
Group Reviewers
KDevelop
Commits
R32:c0d55ad64f6d: Fix definesandincludes test.
Summary

The code as it currently stands do not return any parser arguments for any LanguageType::Other files.
The checks I removed were added for this commit: https://phabricator.kde.org/R32:1c78a564626a0e5e305383c5fdb36b0fc76073cc
However, I can't find it in the history: https://phabricator.kde.org/source/kdevelop/history/master/plugins/custom-definesandincludes/definesandincludesmanager.cpp
I suspect it wasn't merged properly and got lost.

Anyway, now parserArguments tries to guess language type for a file requested and for ProjectFolderItem LanguageType::Other is returned.

Diff Detail

Repository
R32 KDevelop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
arrowd created this revision.Jun 14 2018, 12:52 PM
Restricted Application added a project: KDevelop. · View Herald TranscriptJun 14 2018, 12:52 PM
Restricted Application added a subscriber: kdevelop-devel. · View Herald Transcript
arrowd requested review of this revision.Jun 14 2018, 12:52 PM
mwolff accepted this revision.Jun 14 2018, 2:12 PM
mwolff added a subscriber: mwolff.

thanks for fixing the tests! much appreciated

This revision is now accepted and ready to land.Jun 14 2018, 2:12 PM
Closed by commit R32:c0d55ad64f6d: Fix definesandincludes test. (authored by arrowd). · Explain WhyJun 14 2018, 3:03 PM
This revision was automatically updated to reflect the committed changes.
aaronpuchert added a subscriber: aaronpuchert.Jun 15 2018, 10:43 PM

The failures probably came from my change D8634, thanks for fixing it. The commit you mentioned seems to precede that.

Revision Contents
Changeset List

Diff 36164

View Options

plugins/custom-definesandincludes/tests/test_definesandincludes.cpp

Loading...