Compiled latest GTK
Ran gtk4-demo and used WAYLAND_DEBUG to confirm it used the correct shell
tested a top level and a popup
Details
Details
- Reviewers
romangg - Group Reviewers
Plasma - Commits
- R108:fcf9acfec505: Add XDG WmBase support
Diff Detail
Diff Detail
- Repository
- R108 KWin
- Branch
- master
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 2 Build 2: arc lint + arc unit
| autotests/integration/kwin_wayland_test.h | ||
|---|---|---|
| 134 | You could put extra comma for cleaner future history. E.g. enum class ShellSurfaceType { WlShell, XdgShellV5, XdgShellV6, XdgShellStable, }; | |
| autotests/integration/kwin_wayland_test.h | ||
|---|---|---|
| 134 | I disagree. comma at end is just bad style which is accepted by compilers. | |
Comment Actions
I disagree. comma at end is just bad style which is accepted by compilers.
by C++ standard. draft ;-)
Could you please explain why trailing commas are bad?
Comment Actions
I disagree. comma at end is just bad style which is accepted by compilers.
by C++ standard. draft ;-)
Could you please explain why trailing commas are bad?
It's not bad, just IMHO bad style. To me commas separate list members. After the last member a comma doesn't make sense. If I see code where there's a comma after the last member it always looks sloppy to me. A Dev reordered the code and didn't clean up or copy and paste without cleaning up. As you might have noticed I value clean code extremely.
I also value not affecting other lines. Thus in class initializers I prefer comma going first over trailing to minimize changes. But for last enum member I prefer no comma even if it means the next addition causes an unaffected line to change too.
Comment Actions
+1, no stray commas, please :)
(should probably be added in the kdelibs coding style page)