Nice work! I must be missing something though, since I cannot seem to create a new mask and save it. Pressing the edit button doesn't seem to do anything for me?

Great to hear that you're working together!

Sorry, I made a clean build and the crash has gone! Now I can press the Mask button, but still cannot create any mask (I don't know how to do that) :)

Anyway, I will wait till the updated version of the patch :)

Thanks for the report, the bug was indeed there (due to use of an uninitialized pointer), I have fixed it. I am working on fixing other crashes, I will update the diff after that.

For selecting a mask (or editing, deleting, etc.), you have to enable the "Gamut Masks" docker, select a mask in the list and press "set" button in the docker bottom. The selector then sets the mask and you can toggle it on to display it.

I will work on the UI to make it clear for the user. The UI is still rather experimental :)

I'm sorry, but this patch doesn't seem to apply to current master. Could you please rebase it?

The following patch should be applied to make it compile (looks like there were some local changes not included into the diff :) ):

Hi, @amedonosova!

I have managed to build your patch, but either I don't understand something, or it is impossible to create a mask. Could you please tell how can I create a mask?

Here is what I tried:

Hi, @dkazakov ,

thank you for testing my diff.

You should have three testing masks visible in the gamut masks docker, like this:

The resources should be installed into share/gamutmasks, but for some reason they are not showing up. I will try to reproduce this bug here.

The buttons do nothing, unless a mask is selected. To create a new one, you select a mask, edit and save as new. The idea is that the artist has some basic color harmony templates available to either use directly, or build upon.

It fails to load the resources for some reason with the following debug output:

QStandardPaths: XDG_RUNTIME_DIR not set, defaulting to '/tmp/runtime-appimage'
QXcbConnection: XCB error: 148 (Unknown), sequence: 180, resource id: 0, major code: 140 (Unknown), minor code: 20
krita.lib.widgets: Loading resource  "/home/appimage/appimage-workspace/krita-inst/share/krita/gamutmasks/new_mask.kgm" failed
krita.lib.widgets: Loading resource  "/home/appimage/appimage-workspace/krita-inst/share/krita/gamutmasks/testing1.kgm" failed
krita.lib.widgets: Loading resource  "/home/appimage/appimage-workspace/krita-inst/share/krita/gamutmasks/testing2.kgm" failed

Good evening, @dkazakov,

I ran a clean build on my computer and cannot reproduce the problem. However, I'm think the problem might be that my patch does not contain the binary files needed, just mentions that they exist (when I try to apply the patch, git tells me it cannot apply "without full index line"). I'm not sure how to solve it, so for now I'm uploading them here:

Can you please confirm that it is the case? If it is, could you try with the files I uploaded here, until I find a solution to the patch problem?

I'm sorry for the inconvenience.

Hm, that is strange -- how do you create the patch? Do you make a commit with git that you export with git format-patch?

Hi, @amedonosova!

Yes, the files were empty for some reason. I have downloaded them manually and managed to test. Here are my notes:

1. In general, the patch works very nicely and I like the idea of it.
2. [UIX] I would really prefer to have some button to start editing of an empty circular mask. Just to avoid the cases like I faced before. It is also much more intiutuve for a user to press "Create now gamut mask" button, then to edit something :)
3. [UIX] I'm not sure about the correct place for a button "Apply gamut mask to a selector". I would expect this button to be in the selector itself, not in the editor. Are you going to extend these gamut masks to other color selectors? If so, such placement would create troubles.
4. It general the patch looks very solid. I tried to make some nasty things, like closing/switching/saving the "edit gamut mask document" during editing. The docker handled this case correctly, without any troubles :) Although it might be a good idea to hide editing mode controls when the user switches out of the gamut mask document. Right now it looks a bit non-obvious :)
5. [crash] Start editing the mask, then remove all shape layers of the mask document, then press save -> crash :)
6. Are you going to extend this feature to more popular color selectors like Advanced Color Selector?

In D13525#285130, @rempt wrote:

Hm, that is strange -- how do you create the patch? Do you make a commit with git that you export with git format-patch?

I have, quite naively, created the diff like this "git diff master my-branch > file.diff". On my next update I will try either binary patch from format-patch, or uploading with arcanist.

In D13525#285565, @dkazakov wrote:

1. In general, the patch works very nicely and I like the idea of it.

Thanks.

2. [UIX] I would really prefer to have some button to start editing of an empty circular mask. Just to avoid the cases like I faced before. It is also much more intiutuve for a user to press "Create now gamut mask" button, then to edit something :)

Yes, you are right, I will work on it. There are some other usability issues, which are partly connected to this (mainly that the editing is really fragile right now, if the user doesn't create the shape with solid, but transparent, background, she will end up with a mask not showing in the selector).

3. [UIX] I'm not sure about the correct place for a button "Apply gamut mask to a selector". I would expect this button to be in the selector itself, not in the editor. Are you going to extend these gamut masks to other color selectors? If so, such placement would create troubles.

The plan is to extend it to other selectors. I was in contact with Ahmed Hussein, who wanted to reuse my code for bug 373922. I don't know about his progress so far.

Maybe we could have a toolbar for mask selection, that could be reused in the selectors. Or something, that would replace the masks docker altogether (like the current toolbar in the selector, but with a button that would show a popup with what now is in the masks docker; or something totally different). I would have to think about that some more. If you have any ideas, please share :)

4. It general the patch looks very solid. I tried to make some nasty things, like closing/switching/saving the "edit gamut mask document" during editing. The docker handled this case correctly, without any troubles :) Although it might be a good idea to hide editing mode controls when the user switches out of the gamut mask document. Right now it looks a bit non-obvious :)

I will implement the hiding. Also, if you see anything subpar in the code, please, let me know. I'm rather a beginner coder, there are still things I do not understand well and I'm not always able to think through all the consequences :)

5. [crash] Start editing the mask, then remove all shape layers of the mask document, then press save -> crash :)

Thanks, I will fix that.

6. Are you going to extend this feature to more popular color selectors like Advanced Color Selector?

That's the plan (though, I did not plan to do it myself :). Please, see pt. 3).

Hi, @amedonosova!

I have pushed your patch into a separate branch amedonosova/gamut-masking. Please base your next patches on the top of it :)

https://commits.kde.org/krita/dbe05327705fde0b0d6b56451322e4deddc6fc24