Simplify signal handling between engine and models
ClosedPublic
Actions

Authored by tbaumgart on Jun 13 2018, 4:19 PM.

Details

Reviewers

wojnilowicz

Commits

Summary

Make the signal connection and disconnection more readable

Repository

R261 KMyMoney

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

tbaumgart requested review of this revision.Jun 13 2018, 4:19 PM

tbaumgart created this revision.

Beside trhee comments, it looks good to me.

kmymoney/kmymoney.cpp
465–502	Do you need to see that "file" is of MyMoneyFile kind? If not, then I would write const auto file = MyMoneyFile::instance();
467	Why not? const auto accountsModel = file->accountsModel();
508	Same here, i.e q->disconnect(file, nullptr, file->accountsModel(), nullptr);

This revision is now accepted and ready to land.Jun 16 2018, 11:47 AM

I will make the requested changes and commit. I still have to get used to auto :-)

kmymoney/kmymoney.cpp
508	Nope, that won't work. `MyMoneyFile::instance() != Models::instance()`

This revision was automatically updated to reflect the committed changes.

tbaumgart marked an inline comment as done.

			Path	Packages
M			kmymoney/kmymoney.cpp (128 lines)
M			kmymoney/models/ledgermodel.h (12 lines)
M			kmymoney/models/ledgermodel.cpp (19 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	36104	a4e991f		Jun 13 2018, 4:19 PM	★	★
Diff 2	36226	a4e991f	R261:1b0a620291afda776888fb8c99c9efba2afde41e	Jun 16 2018, 2:19 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
f60ef13a7f3e	53f144c28326	a4e991f8174a	Thomas Baumgart	Simplify signal handling between engine and models (Show More…)	Jun 13 2018, 4:18 PM