Differential D13518

Speedup nsis generation by using nsis
ClosedPublic
Actions

Authored by vonreth on Jun 13 2018, 3:37 PM.

Details

Reviewers
kfunk
bcooksley
Commits
R138:ec9b75700ccf: Speedup nsis generation by using 7z
Summary

Instead of generating a 7z and a lzma compressed archive as we do now, reuse the generated 7z archive.

The compression in nsis is slow as it uses an old algorithm and only one core, using 7z will speedup packaging.

Downside, the nsis estimated installation size is wrong.

Diff Detail

Repository
R138 Craft
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
vonreth requested review of this revision.Jun 13 2018, 3:37 PM
vonreth created this revision.
vonreth edited the summary of this revision. (Show Details)Jun 13 2018, 3:40 PM
bcooksley accepted this revision.Jun 14 2018, 6:38 AM

Looks fine to me.

This revision is now accepted and ready to land.Jun 14 2018, 6:38 AM
kfunk accepted this revision.Jun 14 2018, 11:50 AM
kfunk added inline comments.
bin/Packager/NullsoftInstallerPackager.py
168

Could be simplified: return func()

bin/Packager/PortablePackager.py
28

Could be simplified: return func()

Closed by commit R138:ec9b75700ccf: Speedup nsis generation by using 7z (authored by vonreth). · Explain WhyJun 14 2018, 12:17 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 36151

View Options

bin/Packager/MultiCollectionPackager.py

Loading...
View Options

bin/Packager/NullsoftInstaller.nsi

Loading...
View Options

bin/Packager/NullsoftInstallerPackager.py

Loading...
View Options

bin/Packager/PortablePackager.py

Loading...
View Options

bin/Packager/TypePackager.py

Loading...