This patch adds support for validating all signatures present in the PDF at once
and show the validation summary as popup in the page view.
Depends on D14816
chinmoyr |
This patch adds support for validating all signatures present in the PDF at once
and show the validation summary as popup in the page view.
Depends on D14816
Open a signed PDF and click on "Validate All Signatures".
No Linters Available |
No Unit Test Coverage |
part.cpp | ||
---|---|---|
1556 | I think atleast is not a word. Also does the user really care about this "you have a signature form", why are signature forrms more important than the rest? | |
3571 | atleast is two words i think, also "has problem" is not correct either i think. | |
part.h | ||
237 | ideally we should not have "slot" in the name, just what the function does, also Sig -> Signature please, no need to make it shorter :) | |
ui/pageview.cpp | ||
5550 | I don't think this logic belongs here, it should be in document, this is not an "UI" thing, more a "core" thing. What do you think? |
This document has forms of which atleast one is a signature form.
I feel like an implementation detail is leaking out here. Even though internally the signature is just another form, from a user's perspective, the signature is something else. How about this?
This document has forms. [Show forms] [x] This document is digitally signed. [Show signature] [x]
Or even:
This document has forms and is digitally signed. [Show forms] [x] [Show signature] [x]
And no, "atleast" isn't a word in English. :)
Went with @ngraham's suggestion of showing a separate message for signature. But the "Show Signature" button will
show the signature panel widget and not the forms.
ss:
This has been merged as part of https://commits.kde.org/okular/a234a902dcfff249d8f1d41dfbc257496c81d84e
Abandoning because phabricator doesn't have a "merged as part of a different commit" option.