Differential D13482

Implement support for the Voice and Call interfaces
ClosedPublic
Actions

Authored by aleksanderm on Jun 11 2018, 4:59 PM.

Details

Reviewers

jgrulich

Group Reviewers

Frameworks

Commits

R281:7b9d2badd52a: Implement support for the Voice and Call interfaces

Summary

The Voice and Call interfaces were introduced in ModemManager 1.6, and
they provide access to voice-related operations (e.g. start a call,
hangup a call, get notified of incoming calls..).

This commit adds bindings for those 2 interfaces in ModemManagerQt.

Diff Detail

Repository

R281 ModemManagerQt

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

aleksanderm created this revision.Jun 11 2018, 4:59 PM

Restricted Application added a subscriber: kde-frameworks-devel. · View Herald TranscriptJun 11 2018, 4:59 PM

aleksanderm requested review of this revision.Jun 11 2018, 4:59 PM

Looks good to me. Having a test for this would be nice, but looks that not all interfaces are unit tested.

This revision is now accepted and ready to land.Jun 13 2018, 11:55 AM

Closed by commit R281:7b9d2badd52a: Implement support for the Voice and Call interfaces (authored by aleksanderm, committed by jgrulich). · Explain WhyJun 18 2018, 6:25 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

		Path
M		src/CMakeLists.txt (16 lines)
A	M	src/call.h (108 lines)
A	M	src/call.cpp (157 lines)
A	M	src/call_p.h (53 lines)
M		src/dbus/CMakeLists.txt (2 lines)
A	M	src/dbus/callinterface.h (86 lines)
A	M	src/dbus/callinterface.cpp (25 lines)
M		src/dbus/dbus.h (3 lines)
M		src/dbus/fakedbus.h (3 lines)
A	M	src/dbus/introspection/org.freedesktop.ModemManager1.Call.xml (115 lines)
A	M	src/dbus/introspection/org.freedesktop.ModemManager1.Modem.Voice.xml (90 lines)
A	M	src/dbus/voiceinterface.h (69 lines)
A	M	src/dbus/voiceinterface.cpp (25 lines)
M		src/generictypes.h (5 lines)
A	M	src/modemvoice.h (107 lines)
A	M	src/modemvoice.cpp (149 lines)
A	M	src/modemvoice_p.h (51 lines)