Remove "Use Default Location" button in settings window
AbandonedPublic

Authored by ngraham on Jun 10 2018, 9:56 PM.

Details

Reviewers
None
Group Reviewers
Dolphin
Summary

The window itself already has a button to reset everything to default settings. No other field or UI control has its own private button that resets it to the default value. So this one probably isn't needed.

Depends on D12571

Test Plan

Before:

After:

Diff Detail

Branch
remove-default-button-for-location-field (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
ngraham requested review of this revision.Jun 10 2018, 9:56 PM
ngraham created this revision.
ngraham edited the test plan for this revision. (Show Details)Jun 10 2018, 9:57 PM
ngraham set the repository for this revision to R318 Dolphin.
Restricted Application added a project: Dolphin. · View Herald TranscriptJun 10 2018, 9:57 PM
Restricted Application added a subscriber: kfm-devel. · View Herald Transcript
ngraham edited the summary of this revision. (Show Details)Jun 10 2018, 9:57 PM

I'm not 100% convinced. The Defaults button resets all dolphin settings, while this one resets only this particular option.
The problem is we don't know if someone relies on this "feature", and in theory we could break someone else's workflow (unlikely, but still).

Some more reasons why we might want to keep the button around:

  • Nobody filed a bug to remove it, AFAIK.
  • Firefox has the very same button.
  • The after screenshot imho looks worse, since now we have a huge button that stands out.
markg added a subscriber: markg.Jun 13 2018, 8:20 PM

I'm not 100% convinced. The Defaults button resets all dolphin settings, while this one resets only this particular option.
The problem is we don't know if someone relies on this "feature", and in theory we could break someone else's workflow (unlikely, but still).

Some more reasons why we might want to keep the button around:

  • Nobody filed a bug to remove it, AFAIK.
  • Firefox has the very same button.
  • The after screenshot imho looks worse, since now we have a huge button that stands out.

I'd remove both buttons.
Sure, they are "nice to have", but not that useful. I can't even remember when i last used any of those features and i've been using dolphin for years now (that could also just be my workflow, not needing those features).

ngraham added a comment.EditedJun 14 2018, 1:15 PM

What's the use case for actually clicking on the {use Default Location} button instead if the reset all button on the bottom? Again, no other control has its own private "reset only me to default settings" button, so it stands out.

Friendly ping!

Anyone? Does anyone use this? What's the use case for it instead of simply clicking on the Default button at the bottom of the window?

mmustac added a subscriber: mmustac.EditedJul 25 2018, 6:57 AM

Personally I had never used this buttons since I am a happy dolphin user but maybe becuase my default location is and will stay my home directory.
Regarding your question: The reason will be to just reset the location field. When someone changed the view settings underneath and clicks on the default button these settings will also get lost even this was not intended.
For me it would not hurt to remove both like Mark proposed. On the other hand people are always complaining when Gnome removes somtheing ... well I am not sure and can't speak for all users out there just wanted to share my point of view.

ngraham abandoned this revision.Aug 5 2018, 4:31 AM

I guess there's not really a win here.