| davidedmundson |
| KWin |
The slide effect doesn't completely remove forced blur and background
contrast roles. According to EffectWindow::setData implementation,
void EffectWindowImpl::setData(int role, const QVariant &data) { if (!data.isNull()) dataMap[ role ] = data; else dataMap.remove(role); emit effects->windowDataChanged(this, role); }
in order to delete previously set data, we should pass a null variant.
| Automatic diff as part of commit; lint not applicable. |
| Automatic diff as part of commit; unit tests not applicable. |
Heh, it made me find a bug (D13478)
As for this.
It's storing a correct value vs deleting the value because you know that value happens to be considerered the default.
Not worse, but it's not exactly solving anything either.
Note presentwindows has the same setData(...,false);
Agree, it doesn't fix anything, that's to cleanup after itself. Slide effect set force roles before so it should delete them. (yet, I'm still in between refcounting force roles and blindly setting/deleting force roles)
Either way, storing previous values of force roles is error-prone.
Completely agree on that part.