Remove pointer constraint on resource unbind

Authored by romangg on Jun 10 2018, 3:49 PM.



A client might delete its pointer lock/confinement object. This is supposed to
directly remove the pointer lock/confinement in KWin, but did not explicitly
until now.

BUG: 388885

Test Plan

Tested manually with Neverball, Nexuiz and the new pointer constraints test
application. The pointer constraints autotest is also appended.

Diff Detail

R108 KWin
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.
romangg created this revision.Jun 10 2018, 3:49 PM
Restricted Application added a project: KWin. · View Herald TranscriptJun 10 2018, 3:49 PM
Restricted Application added a subscriber: kwin. · View Herald Transcript
romangg requested review of this revision.Jun 10 2018, 3:49 PM
graesslin added inline comments.

On the resource there should be an unbound signal.

romangg updated this revision to Diff 35986.Jun 11 2018, 6:18 AM
romangg marked an inline comment as done.
  • Spy on SurfaceInterface signal in test

Not sure how I get the resource of the proxy, but I'm spying now on the KWayland::Server::SurfaceInterface::pointerConstraintsChanged signal, what also works.

davidedmundson accepted this revision.Jun 11 2018, 10:48 AM
davidedmundson added a subscriber: davidedmundson.

One minor request.


generally speaking in kwayland terms:

Resource == the thing on the server
Proxy == the thing on the client

So "resource of the proxy" is confusing.

IMHO you're now watching a better signal than unbound, as it happens after the pointers are cleared in surface_interface, but please rename the spy to something more fitting.

This revision is now accepted and ready to land.Jun 11 2018, 10:48 AM
This revision was automatically updated to reflect the committed changes.
romangg marked 2 inline comments as done.