Differential D13440

[effects/dimscreen] Use QSet for checking whether activated window asks for permissions
ClosedPublic
Actions

Authored by zzag on Jun 8 2018, 11:57 PM.

Details

Reviewers
davidedmundson
Group Reviewers
KWin
Commits
R108:7550d2a02064: [effects/dimscreen] Use QSet for checking whether activated window asks for…
Summary

Do not construct QStringList with classes of windows that ask for
permissions. Instead, create a static set of those window classes (to
avoid the unnecessary construction of QStringList and make lookups
faster).

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
zzag created this revision.Jun 8 2018, 11:57 PM
Restricted Application added a project: KWin. · View Herald TranscriptJun 8 2018, 11:57 PM
Restricted Application added a subscriber: kwin. · View Herald Transcript
zzag requested review of this revision.Jun 8 2018, 11:57 PM
davidedmundson accepted this revision.Jun 8 2018, 11:59 PM
This revision is now accepted and ready to land.Jun 8 2018, 11:59 PM
zzag retitled this revision from [effects/dimscreen] Use QSet for checking whether added window asks for permissions to [effects/dimscreen] Use QSet for checking whether activated window asks for permissions.Jun 9 2018, 12:06 AM
zzag edited the summary of this revision. (Show Details)Jun 9 2018, 12:38 AM
Closed by commit R108:7550d2a02064: [effects/dimscreen] Use QSet for checking whether activated window asks for… (authored by zzag). · Explain WhyJun 9 2018, 9:28 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Meffects/dimscreen/dimscreen.cpp (18 lines)

Diff 35879

View Options

effects/dimscreen/dimscreen.cpp

Loading...