Differential D13429

Remove calls that are only forward calling
AbandonedPublic
Actions

Authored by tcanabrava on Jun 8 2018, 1:51 PM.

Details

Reviewers
hindenburg
Group Reviewers
Konsole
Summary

If those slots are actually meant to be exported,
we can move the private ones to public as they just
called the private ones.

Remove calls from ViewManager that are unrelated

Diff Detail

Repository
R319 Konsole
Branch
removeUneeded
Lint
No Linters Available
Unit
No Unit Test Coverage
tcanabrava created this revision.Jun 8 2018, 1:51 PM
Restricted Application added a project: Konsole. · View Herald TranscriptJun 8 2018, 1:51 PM
Restricted Application added a subscriber: konsole-devel. · View Herald Transcript
tcanabrava requested review of this revision.Jun 8 2018, 1:51 PM
hindenburg added a comment.Jun 9 2018, 11:04 PM

These are for use via dbus; example: qdbus $KONSOLE_DBUS_SERVICE $KONSOLE_DBUS_WINDOW defaultProfile

We don't want to blindly remove them

tcanabrava added a comment.Jun 11 2018, 7:53 AM
In D13429#276446, @hindenburg wrote:

These are for use via dbus; example: qdbus $KONSOLE_DBUS_SERVICE $KONSOLE_DBUS_WINDOW defaultProfile

We don't want to blindly remove them

true. but we can remove the *forward calls*, - use only the calls that are exposed to the dbus.
I'll update the patch.

tcanabrava abandoned this revision.Jun 12 2018, 4:53 PM

Revision Contents
Changeset List

PathPackages
Msrc/ViewManager.h (26 lines)
Msrc/ViewManager.cpp (30 lines)

Diff 35835

View Options

src/ViewManager.h

Loading...
View Options

src/ViewManager.cpp

Loading...