Differential D13419

show installed size for all packages
ClosedPublic
Actions

Authored by vanini on Jun 7 2018, 8:03 PM.

Details

Reviewers
sitter
Commits
R550:6d109d77e30d: show installed size for all packages
Summary

Show installed size also for packages which are not installed, using the
size of the candidate version.

Depends on D13412

Diff Detail

Repository
R550 Muon
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
vanini requested review of this revision.Jun 7 2018, 8:03 PM
vanini created this revision.
sitter added a comment.Jun 8 2018, 11:18 AM

The duplicated if (package->isInstalled()) { is a bit meh.

src/PackageModel/PackageModel.cpp
69–73

Random thought: maybe Package should grow a convenience function for this. It seems to me that most times one would want *any* installed size.

sitter accepted this revision.Jun 8 2018, 11:19 AM
This revision is now accepted and ready to land.Jun 8 2018, 11:19 AM
vanini updated this revision to Diff 36317.Jun 19 2018, 10:02 AM
  • update with new function in QApt::Package

Depends on D13600

Closed by commit R550:6d109d77e30d: show installed size for all packages (authored by vanini). · Explain WhyJun 19 2018, 12:24 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/PackageModel/PackageModel.cpp (9 lines)

Diff 36325

View Options

src/PackageModel/PackageModel.cpp

Loading...