Add test to verify the Alternative Menu
ClosedPublic

Authored by bdhruve on Jun 7 2018, 4:16 PM.

Details

Reviewers
bshah
sitter
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Commits
R1005:073e6da1e9fc: Add test to verify the Alternative Menu
Summary
  • Opens the Alternative menu by right click at application launcher
  • Select the Alternatives option
  • Select the Application menu
  • Switches to Application menu
  • Check if the menu style has changed
Test Plan

Test is not working properly under plasma desktop suite

Diff Detail

Repository
R1005 Neon OpenQA Components
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
bdhruve requested review of this revision.Jun 7 2018, 4:16 PM
bdhruve created this revision.

To explain the comment in test plan, while testing it in plasma_desktop suite it is not able to assert the folder_desktop screen even though the last screen-shot in plasma-favorites.pm is folder-desktop screen. However test itself works fine individually.

sitter accepted this revision.Jun 8 2018, 8:41 AM

I'd undo the launcher switch before ending the test. Besides that, awesome work.

I am not too worried about it failing in the suite as that should be easy to debug via jenkins' output.

neon/tests/plasma/plasma_alternatives.pm
66

Following the example of the favorites test I'd say this test should roll itself back to kickoff. By not changing the session *too* much future additional tests won't fall over on basic assumptions such as what the launcher is.

This revision is now accepted and ready to land.Jun 8 2018, 8:41 AM
bdhruve updated this revision to Diff 36003.Jun 11 2018, 12:55 PM

Reset back to kickoff at end of test

Owners added a reviewer: Restricted Owners Package.Jun 11 2018, 12:55 PM

As @bshah pointed on IRC this may or may not need updating of the needles.

The plasma-folder test now switches the background to a constant color. Some of the needle failures were due to plasma being partially translucent and thus the wallpaper bleeding into the needles. As we didn't want to disable all desktop effects, I instead opted to fixate the color. As a result your new needles might not match. However, out of the existing needles only one had a problem there, so you may be fine.

In any case, I am fine with landing it and fixing it through jenkins if redoing the needles locally seems like too much work.

As @bshah pointed on IRC this may or may not need updating of the needles.

The plasma-folder test now switches the background to a constant color. Some of the needle failures were due to plasma being partially translucent and thus the wallpaper bleeding into the needles. As we didn't want to disable all desktop effects, I instead opted to fixate the color. As a result your new needles might not match. However, out of the existing needles only one had a problem there, so you may be fine.

In any case, I am fine with landing it and fixing it through jenkins if redoing the needles locally seems like too much work.

I will push these changes and once Jenkins picks up the changes, will fix them if required.

This revision was automatically updated to reflect the committed changes.