Exceptions are enabled globally by kde_enable_exceptions, so there is no need for separate kde_target_enable_exceptions.
target_compile_features should be useless as we already should have all features we request by requesting a compiler compatible with C++14.
Details
Details
- Reviewers
tbaumgart - Group Reviewers
KMyMoney - Commits
- R261:7a3aba071f63: Remove redundant CMake statements
Diff Detail
Diff Detail
- Repository
- R261 KMyMoney
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
What about the target_compile_features in kmyoney/settings/CMakeLists.txt? Why were those instructions added in the first place? Are they possibly required on some platform? Did you check all of them?
Comment Actions
I think they could be removed as well. From my understanding those instructions were added to use features from C++14 on compilers not yet fully compatible with C++14. They've implemented only subset of those features and we wanted to use them, but now we demand C++14 compliant compiler, so they are redundant right now.
I did not check all platforms.
Comment Actions
We'll see if we might have to add them at a later point in time for specific environments. So far, we don't know and don't see a necessity.