Differential D13403

Android: Make it possible to override a target's APK directory
ClosedPublic
Actions

Authored by apol on Jun 7 2018, 12:28 PM.

Details

Reviewers

vkrause

Group Reviewers

Frameworks

Commits

R240:d6cc583f32a4: Android: Make it possible to override a target's APK directory

Summary

Some projects such as marble do some operations with the APK directory
before building. This allows us the project to copy the apk directory
over to the build directory and do whatever it pleases.

Test Plan

Built Marble

Diff Detail

Repository

R240 Extra CMake Modules

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

apol created this revision.Jun 7 2018, 12:28 PM

Restricted Application added projects: Frameworks, Build System. · View Herald TranscriptJun 7 2018, 12:28 PM

Restricted Application added subscribers: kde-buildsystem, kde-frameworks-devel. · View Herald Transcript

apol requested review of this revision.Jun 7 2018, 12:28 PM

apol added a dependent revision: D13404: Make it possible to build Marble with KDE Android tooling.

Ping

vkrause added a subscriber: vkrause.Jun 19 2018, 8:13 AM

vkrause added inline comments.

toolchain/ECMAndroidDeployQt.cmake
59	This seems to introduce a new assumption on ANDRDOID_NDK_PLATFORM being set as an environment variable? Should we check for that/document that, or am I entirely misreading this somehow? The rest looks good to me.

Remove unrelated change

Harbormaster completed remote builds in B543: Diff 37024.Jul 1 2018, 11:40 PM

vkrause accepted this revision.Jul 2 2018, 6:52 AM

This revision is now accepted and ready to land.Jul 2 2018, 6:52 AM

Closed by commit R240:d6cc583f32a4: Android: Make it possible to override a target's APK directory (authored by apol). · Explain WhyJul 4 2018, 3:05 PM

This revision was automatically updated to reflect the committed changes.

Showing Only Differences

This revision modifies 2 more files that are hidden because they were not modified between selected diffs and they have no inline comments.

Revision Contents
Changeset List

			Path	Packages
M			toolchain/ECMAndroidDeployQt.cmake (15 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	35751	5cf0be9		Jun 7 2018, 12:28 PM	★	★
Diff 2	37024	484d5f4	Remove unrelated change	Jul 1 2018, 11:40 PM	★	★
Diff 3	37147	484d5f4	R240:d6cc583f32a4ca0f05ccad8e30cf84b74e9e9561	Jul 4 2018, 3:04 PM	★	★

	Status	Author	Revision
	Closed	apol	D13404 Make it possible to build Marble with KDE Android tooling
	Closed	apol	D13403 Android: Make it possible to override a target's APK directory

Diff 37147

View Options

toolchain/ECMAndroidDeployQt.cmake