Differential D13387

Add KDEVPLATFORMSHELL_EXPORT annotations to ProblemStoreNode classes.
ClosedPublic
Actions

Authored by arrowd on Jun 6 2018, 7:32 PM.

Details

Reviewers
kfunk
Group Reviewers
KDevelop
Commits
R32:27f2d0ca0106: Add KDEVPLATFORMSHELL_EXPORT annotations to ProblemStoreNode classes.
R32:7945dcf754f3: Merge remote-tracking branch 'origin/5.2'
Summary

Without marking these classes as exported, dynamic_cast<>'s on them fail. This was causing test_problemstore to fail on FreeBSD.
This problem can be made visible if you move ProblemStoreNode constructor into a .cpp belonging to KDevPlatformShell library. The test_problemstore would fail to link then, due to unresolved references to "typeinfo".

Test Plan

test_problemstore now passes on FreeBSD

Diff Detail

Repository
R32 KDevelop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
arrowd created this revision.Jun 6 2018, 7:32 PM
Restricted Application added a project: KDevelop. · View Herald TranscriptJun 6 2018, 7:32 PM
Restricted Application added a subscriber: kdevelop-devel. · View Herald Transcript
arrowd requested review of this revision.Jun 6 2018, 7:32 PM
kfunk accepted this revision.Jun 6 2018, 8:13 PM
This revision is now accepted and ready to land.Jun 6 2018, 8:13 PM
Closed by commit R32:27f2d0ca0106: Add KDEVPLATFORMSHELL_EXPORT annotations to ProblemStoreNode classes. (authored by arrowd, committed by kfunk). · Explain WhyJun 6 2018, 8:17 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 35709

View Options

kdevplatform/shell/problemstorenode.h

Loading...