Allow for custom colors for each painting assistant
ClosedPublic

Authored by scottpetrovic on Jun 5 2018, 9:03 PM.

Details

Reviewers
rempt
Group Reviewers
Krita
Summary

This takes the assistant colors one step further. Each assistant can now use a normal "global" color, or it can use its own special custom color.

The options to change the color of the assistant is on the tool options when it is selected.

This also adds the ability for the global color to be saved to the KRA and painting assistant. That property was not saved previously.

Test Plan

Changed the colors and opacity of the custom colors to see it update.

Check and uncheck the "use custom color" to make sure the UI state management works

Test out loading and saving with KRA

test out loading and saving with painting assistant files.

Tried having one, or multiple assistants with different settings.

Diff Detail

Repository
R37 Krita
Lint
Lint Skipped
Unit
Unit Tests Skipped
scottpetrovic created this revision.Jun 5 2018, 9:03 PM
Restricted Application added a project: Krita. ยท View Herald TranscriptJun 5 2018, 9:03 PM
scottpetrovic requested review of this revision.Jun 5 2018, 9:03 PM
rempt accepted this revision.Jun 5 2018, 9:22 PM
rempt added a subscriber: rempt.

Cool stuff, please push since feature/string freeze is tomorrow (CEST). We can check for the other thing I mentioned afterwards. Note: I have eyeballed the diff, not built it yet...

libs/ui/kis_painting_assistants_decoration.cpp
478

I'm pretty sure we've got code to serialize and deserialize QColor to settings already. It's a bit late, but please prod me tomorrow if I haven't figured out where it is already.

This revision is now accepted and ready to land.Jun 5 2018, 9:22 PM
scottpetrovic closed this revision.Jun 8 2018, 1:12 PM

This is pushed out...closing.