Differential D1337

Improve API: KoReportData::data() -> create()
ClosedPublic
Actions

Authored by piggz on Apr 6 2016, 9:13 PM.

Details

Reviewers
staniek
Commits
R14:c4c03c4084a9: Improve API: KoReportData::data() -> create()
Summary

from calligra 2.9 aaac84665edc

Simple API change. Needs additional change to Kexi

"Use KoReportData as const when it's enough" 7289e60fdf1e6bf4 (also to kexi.git)

Test Plan

Compile

Diff Detail

Repository
R14 KReport
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
piggz updated this revision to Diff 3179.Apr 6 2016, 9:13 PM
piggz retitled this revision from to Improve API: KoReportData::data() -> create().
piggz updated this object.
piggz edited the test plan for this revision. (Show Details)
piggz added a reviewer: staniek.
Restricted Application added a project: KReport. · View Herald TranscriptApr 6 2016, 9:13 PM
staniek accepted this revision.Apr 16 2016, 9:16 PM
staniek updated this object.
staniek edited edge metadata.

Good. Let's always paste calligra 2.9's revision in the commit message like I did above.

This revision is now accepted and ready to land.Apr 16 2016, 9:17 PM
Closed by commit R14:c4c03c4084a9: Improve API: KoReportData::data() -> create() (authored by piggz). · Explain WhyApr 25 2016, 8:35 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 3521

View Options

src/common/KReportData.h

Loading...
View Options

src/common/KReportData.cpp

Loading...
View Options

src/plugins/chart/KReportItemChart.cpp

Loading...
View Options

src/renderer/KReportPage.h

Loading...