Differential D13366

Add SignatureEdit widget for FormFieldSignature
AbandonedPublic
Actions

Authored by aacid on Jun 5 2018, 5:09 PM.

Details

Reviewers
chinmoyr
Commits
R223:536095bd9700: Add SignatureEdit widget for FormFieldSignature
Summary

This patch adds SignatureEdit widget which subclasses QAbstractButton and is drawn
when a signature form field is visible. This widget will be used for validating
signatures and viewing their properties.




widget pressed:








Depends on D14748
Diff Detail
Repository 
R223 Okular 
Lint 
Automatic diff as part of commit; lint not applicable.
 
Unit 
Automatic diff as part of commit; unit tests not applicable.
 
chinmoyr created this revision.Jun 5 2018, 5:09 PM
Restricted Application added a project: Okular.  ·  View Herald TranscriptJun 5 2018, 5:09 PM
Restricted Application added a subscriber: okular-devel.  ·  View Herald Transcript
chinmoyr requested review of this revision.Jun 5 2018, 5:09 PM
chinmoyr updated this revision to Diff 36014.Jun 11 2018, 5:19 PM
Rebased on master

Made use of SignatureSummaryDialog and SignaturePropertiesDialog
aacid added inline comments.Jun 26 2018, 2:32 PM
ui/formwidgets.cpp


1123
What's the reason for this custom paint code?
chinmoyr updated this revision to Diff 39466.Aug 11 2018, 5:07 PM
chinmoyr edited the summary of this revision. (Show Details)
chinmoyr added a dependency: D14748: Add signature properties dialog.
Added screenshot

Rebased on master
This revision was not accepted when it landed; it landed in state Needs Review.Aug 14 2018, 2:37 PM
Closed by commit R223:536095bd9700: Add SignatureEdit widget for FormFieldSignature (authored by chinmoyr).  ·  Explain Why
This revision was automatically updated to reflect the committed changes.
chinmoyr reopened this revision.Aug 14 2018, 2:41 PM
aacid commandeered this revision.Jan 10 2019, 10:22 PM
aacid abandoned this revision.
aacid edited reviewers, added: chinmoyr; removed: aacid.
This has been merged as part of https://commits.kde.org/okular/a234a902dcfff249d8f1d41dfbc257496c81d84e



Abandoning because phabricator doesn't have a "merged as part of a different commit" option.
Revision Contents
Changeset List
PathPackages
Mui/formwidgets.h (24 lines)
Mui/formwidgets.cpp (98 lines)
Diff 39713
View Options
ui/formwidgets.h
Loading...
View Options
ui/formwidgets.cpp
Loading...