Don't rely on a layout for the initial resize
AbandonedPublic

Authored by tcanabrava on Jun 5 2018, 3:18 PM.

Details

Reviewers
hindenburg
Group Reviewers
Konsole
Summary

Currently Konsole relies on the SearchTab layout, even when it's
hidden, to set it's initial size. This will break if we change the
tabbar in the future.

See https://phabricator.kde.org/D13174

Diff Detail

Repository
R319 Konsole
Branch
fixInitialWidth
Lint
No Linters Available
Unit
No Unit Test Coverage
tcanabrava created this revision.Jun 5 2018, 3:18 PM
Restricted Application added a project: Konsole. · View Herald TranscriptJun 5 2018, 3:18 PM
Restricted Application added a subscriber: konsole-devel. · View Herald Transcript
tcanabrava requested review of this revision.Jun 5 2018, 3:18 PM

This ignores the profile's terminal size settings; it is not as easy to set the size to 1/2 width by 1/2 height

Getting the Konsole window the correct size has always been a pain.

This ignores the profile's terminal size settings; it is not as easy to set the size to 1/2 width by 1/2 height

Getting the Konsole window the correct size has always been a pain.

Apparently the old code also ignored, but it didn’t mattered much as the width was the width of the search bar. I’ll update this taking into consideration the size of the profile.

tcanabrava abandoned this revision.Jun 6 2018, 5:33 PM

This ignores the profile's terminal size settings; it is not as easy to set the size to 1/2 width by 1/2 height

Getting the Konsole window the correct size has always been a pain.

As usual you are right, and this code is wrong, I'v fixed (hopefully correctly) the initial size of konsole in my branch "One search bar per tab" as code there that broke it, code there should fix it. I'm closing this one.