Allow Compact view with narrower windows
ClosedPublic

Authored by ngraham on Tue, Jun 5, 1:04 PM.

Details

Summary

When the width of the sidebar was reduced, I didn't change the threshold at which the window uses Compact View when it becomes narrower. As a result, Compact View was almost never used in desktop mode, because the threshold at which it triggered was close to the threshold at which the window changes over to mobile view.

This patch corrects the issue and allows the window to switch to Compact View more often.

Test Plan

Discover's main window can now be made small and narrow and it will switch more quickly to Compact view:

Looks really really good now IMHO!

Diff Detail

Repository
R134 Discover Software Store
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ngraham created this revision.Tue, Jun 5, 1:04 PM
Restricted Application added a project: Plasma. · View Herald TranscriptTue, Jun 5, 1:04 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ngraham requested review of this revision.Tue, Jun 5, 1:04 PM
ngraham edited the test plan for this revision. (Show Details)Tue, Jun 5, 1:05 PM
apol accepted this revision.Tue, Jun 5, 3:36 PM

Doubt it makes any difference, but if it makes you happier, go for it. :P

This revision is now accepted and ready to land.Tue, Jun 5, 3:36 PM

It does make me happier! :D

This revision was automatically updated to reflect the committed changes.