Remove Qt module declarations in includes
ClosedPublic

Authored by davidedmundson on Jun 5 2018, 10:56 AM.

Details

Summary

IMHO, there's a fine line between tidying and change for the sake of
change.

But if we are going to change these it should be scripted and all at once

Test Plan

Compiles

Diff Detail

Repository
R108 KWin
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
davidedmundson created this revision.Jun 5 2018, 10:56 AM
Restricted Application added a project: KWin. · View Herald TranscriptJun 5 2018, 10:56 AM
Restricted Application added a subscriber: kwin. · View Herald Transcript
davidedmundson requested review of this revision.Jun 5 2018, 10:56 AM
apol accepted this revision.Jun 5 2018, 1:02 PM
This revision is now accepted and ready to land.Jun 5 2018, 1:02 PM
zzag added a subscriber: zzag.Jun 5 2018, 1:31 PM

Could you please name the script that removes Qt module names from includes? (just curious)

git://anongit.kde.org/kde-dev-scripts

kf5/clean-includes

This was actually done with a mod because that script tried to be fancy in ways that didn't work.

There's tonnes more stuff in that repo, some are 100% safe, some require thorough manual checking after. All have zero docs

zzag added a comment.Jun 5 2018, 1:47 PM

git://anongit.kde.org/kde-dev-scripts

kf5/clean-includes

This was actually done with a mod because that script tried to be fancy in ways that didn't work.

There's tonnes more stuff in that repo, some are 100% safe, some require thorough manual checking after. All have zero docs

Thank you.

graesslin accepted this revision.Jun 5 2018, 4:37 PM
graesslin added a subscriber: graesslin.

Looks like there were quite a few surviving the script during qt5 porting.

Was pushed, phab decided not to close it for some reason.