Use logging categories in a few dataengines
ClosedPublic

Authored by davidedmundson on Jun 5 2018, 9:55 AM.

Details

Test Plan

Compiles

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
davidedmundson created this revision.Jun 5 2018, 9:55 AM
Restricted Application added a project: Plasma. · View Herald TranscriptJun 5 2018, 9:55 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
davidedmundson requested review of this revision.Jun 5 2018, 9:55 AM
mart accepted this revision.Jun 7 2018, 10:16 AM
This revision is now accepted and ready to land.Jun 7 2018, 10:16 AM
This revision was automatically updated to reflect the committed changes.

Build errors with this:

https://build.kde.org/job/Plasma%20plasma-workspace%20kf5-qt5%20SUSEQt5.10/44/console

https://build.neon.kde.org/job/bionic_unstable_kde_plasma-workspace/102/

https://kci.pangea.pub/job/cosmic_unstable_plasma-workspace/

13:46:35 /home/jenkins/workspace/Plasma plasma-workspace kf5-qt5 SUSEQt5.10/dataengines/statusnotifieritem/statusnotifieritem_engine.cpp:76: undefined reference to `DATAENGINE_SNI()'
13:46:35 /home/jenkins/workspace/Plasma plasma-workspace kf5-qt5 SUSEQt5.10/dataengines/statusnotifieritem/statusnotifieritem_engine.cpp:76: undefined reference to `DATAENGINE_SNI()'
13:46:35 CMakeFiles/plasma_engine_statusnotifieritem.dir/statusnotifieritem_engine.cpp.o: In function `StatusNotifierItemEngine::registerWatcher(QString const&)':
13:46:35 /home/jenkins/workspace/Plasma plasma-workspace kf5-qt5 SUSEQt5.10/dataengines/statusnotifieritem/statusnotifieritem_engine.cpp:118: undefined reference to `DATAENGINE_SNI()'
13:46:35 /home/jenkins/workspace/Plasma plasma-workspace kf5-qt5 SUSEQt5.10/dataengines/statusnotifieritem/statusnotifieritem_engine.cpp:118: undefined reference to `DATAENGINE_SNI()'
13:46:35 CMakeFiles/plasma_engine_statusnotifieritem.dir/statusnotifieritem_engine.cpp.o: In function `StatusNotifierItemEngine::unregisterWatcher(QString const&)':
13:46:35 /home/jenkins/workspace/Plasma plasma-workspace kf5-qt5 SUSEQt5.10/dataengines/statusnotifieritem/statusnotifieritem_engine.cpp:126: undefined reference to `DATAENGINE_SNI()'
13:46:35 CMakeFiles/plasma_engine_statusnotifieritem.dir/statusnotifieritem_engine.cpp.o:/home/jenkins/workspace/Plasma plasma-workspace kf5-qt5 SUSEQt5.10/dataengines/statusnotifieritem/statusnotifieritem_engine.cpp:126: more undefined references to `DATAENGINE_SNI()' follow
13:46:35 collect2: error: ld returned 1 exit status

Thanks. Hopefully fixed?

@davidedmundson Seems so. Thank you.