[effects/minimizeanimation] Add more descriptive namespace comments
AbandonedPublic

Authored by zzag on Jun 5 2018, 9:44 AM.

Details

Reviewers
None
Group Reviewers
KWin

Diff Detail

Repository
R108 KWin
Branch
effects-minimizeanimation-namespace-comments
Lint
No Linters Available
Unit
No Unit Test Coverage
zzag created this revision.Jun 5 2018, 9:44 AM
Restricted Application added a project: KWin. · View Herald TranscriptJun 5 2018, 9:44 AM
Restricted Application added a subscriber: kwin. · View Herald Transcript
zzag requested review of this revision.Jun 5 2018, 9:44 AM
zzag added a comment.Jun 5 2018, 10:11 AM

I'm not sure what Kdelibs coding style says about namespace comments, but

namespace KWin
{
namespace Foo
{

// many lines of code

} // namespace Foo
} // namespace KWin

IMHO is much readable. If you're okay to have such namespace comments, maybe namespace comments should be updated in one go.

zzag abandoned this revision.Jun 5 2018, 3:54 PM

Personal opinion: I think such comments like namespace or if after a closing braces don't add any useful information. If I need to know the scope the brace ends I use the editors functionality to highlight it.