Use more contextual strings for some button labels
ClosedPublic

Authored by ngraham on Jun 5 2018, 3:49 AM.

Details

Summary

Every Bluetooth error's "fix this error" button's text is "Fix it". However, some issues are not actually problems per se from the user's perspective, so the text can imply the existence of a problem where none exists.

In the case where the Bluetooth adapter is powered off or disabled, display a more contextually appropriate string instead ("Turn On" and "Enable", respectively)

CCBUG: 394778
FIXED-IN: 5.14

Test Plan

Diff Detail

Repository
R97 Bluedevil
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ngraham created this revision.Jun 5 2018, 3:49 AM
Restricted Application added a project: Plasma. · View Herald TranscriptJun 5 2018, 3:49 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ngraham requested review of this revision.Jun 5 2018, 3:49 AM
ngraham edited the summary of this revision. (Show Details)Jun 5 2018, 3:50 AM
ngraham edited the test plan for this revision. (Show Details)
drosca accepted this revision.Jun 5 2018, 7:48 AM
This revision is now accepted and ready to land.Jun 5 2018, 7:48 AM
This revision was automatically updated to reflect the committed changes.
abetts added a subscriber: abetts.Jun 5 2018, 2:37 PM

+1

I feel this is a must. We are trying to convey that the user needs to enable Bluetooth in order to make it work. There is real issue there. In fact, could we maybe change the color message from RED to something more informational?

Red is for errors, orange is for warnings, and blue is for information. The red is not as harsh as it used to be, but do you think orange would be a more appropriate color?

abetts added a comment.Jun 5 2018, 6:52 PM

Red is for errors, orange is for warnings, and blue is for information. The red is not as harsh as it used to be, but do you think orange would be a more appropriate color?

I think so. Red conveys that there is something wrong about your Bluetooth set up. In fact, I am not even sure if we should have this message at all. Could we have a button that enables/disables bluetooth instead? We can show the warning message only if it doesn't seem to be working? or for example, if it runs into an error when enabling, "then" show a warning sign?

Thoughts?

emateli added a subscriber: emateli.Jun 5 2018, 7:06 PM

In D13346#274446, @abetts wrote:
Could we have a button that enables/disables bluetooth instead? We can show the warning message only if it doesn't seem to be working? or for example, if it runs into an error when enabling, "then" show a warning sign?

Thoughts?

A switch like you mention will function perfectly in this case. Possibly positioned in the same line with the title (next to it or at the right) so then the text and button are not necessary anymore. Also functions in the same way as the tray widget(which has a check box instead of a toggle, but it's close enough)

abetts added a comment.Jun 5 2018, 7:07 PM

In D13346#274446, @abetts wrote:
Could we have a button that enables/disables bluetooth instead? We can show the warning message only if it doesn't seem to be working? or for example, if it runs into an error when enabling, "then" show a warning sign?

Thoughts?

A switch like you mention will function perfectly in this case. Possibly positioned in the same line with the title (next to it or at the right) so then the text and button are not necessary anymore. Also functions in the same way as the tray widget(which has a check box instead of a toggle, but it's close enough)

Agreed, I think we do this for things like Wifi where we don't show a warning sign when Wifi is not enabled.