Differential D13341

Fix bug with file.show in R backend
ClosedPublic
Actions

Authored by sirgienko on Jun 4 2018, 6:58 PM.

Details

Reviewers
asemke
Commits
R55:3a57d5c04c20: In R backend try to open files with unknown mimetype in Cantor script editor…
R55:15bdb4aabb86: In R backend try to open files with unknown mimetype in Cantor script editor…
Summary

In R backend try to open files with unknown mimetype in Cantor script editor and add handling for command without results in rserver




BUG: 296814

FIXED-IN: 18.04.2
Diff Detail
Repository 
R55 Cantor 
Lint 
Automatic diff as part of commit; lint not applicable.
 
Unit 
Automatic diff as part of commit; unit tests not applicable.
 
sirgienko created this revision.Jun 4 2018, 6:58 PM
Restricted Application added a project: KDE Edu.  ·  View Herald TranscriptJun 4 2018, 6:58 PM
Restricted Application added a subscriber: kde-edu.  ·  View Herald Transcript
sirgienko requested review of this revision.Jun 4 2018, 6:58 PM
asemke added inline comments.Jun 4 2018, 8:21 PM
src/backends/R/rexpression.cpp


154
can you please  also check the return code of QProcess::execute() and write out some debug output (executable and file names) in case there was an error?
asemke added a comment.Jun 4 2018, 8:26 PM
18.04.2 might be already a bit too late according to https://community.kde.org/Schedules/Applications/18.04_Release_Schedule. Let's bring this into 18.04.3
sirgienko added a comment.Jun 4 2018, 8:30 PM


In D13341#273866, @asemke wrote:


18.04.2 might be already a bit too late according to https://community.kde.org/Schedules/Applications/18.04_Release_Schedule. Let's bring this into 18.04.3





Well, but I don't see tag yet.
sirgienko updated this revision to Diff 35559.Jun 4 2018, 8:37 PM
Add debug messages and check for returned code
sirgienko marked an inline comment as done.Jun 4 2018, 8:41 PM
sirgienko added inline comments.
src/backends/R/rexpression.cpp


154
Done
sirgienko updated this revision to Diff 35562.Jun 4 2018, 9:01 PM
sirgienko marked an inline comment as done.
Change debug messeges
cfeck added a subscriber: cfeck.Jun 4 2018, 9:03 PM
Deadline for 18.04.2 fixes is 23:59 UTC, so three hours from now.
asemke accepted this revision.Jun 4 2018, 9:04 PM
This revision is now accepted and ready to land.Jun 4 2018, 9:04 PM
Closed by commit R55:15bdb4aabb86: In R backend try to open files with unknown mimetype in Cantor script editor… (authored by sirgienko).  ·  Explain WhyJun 4 2018, 9:07 PM
This revision was automatically updated to reflect the committed changes.
Revision Contents
Changeset List
Diff 35564
View Options
src/backends/R/rexpression.cpp
Loading...
View Options
src/backends/R/rserver/rserver.cpp
Loading...