Initial content for card
ClosedPublic

Authored by fabianr on Jun 4 2018, 6:52 PM.

Details

Reviewers
mart
Group Reviewers
VDG
Commits
R985:f69e55133033: Initial content for card
Summary

Merge branch 'master' into card

Added recomendation for aspect ratio

Add3d remoendation for padding to card

added 2 images for cards

Added recomendation about focus on one bit of content to cards

Merge branch 'master' into card

Diff Detail

Repository
R985 KDE Human Interface Guidelines
Branch
card
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 1266
Build 1280: arc lint + arc unit
fabianr requested review of this revision.Jun 4 2018, 6:52 PM
fabianr created this revision.
fabianr updated this revision to Diff 36440.Jun 21 2018, 11:08 AM
  • Added videos with card layout behaviour
fabianr updated this revision to Diff 37151.Jul 4 2018, 4:01 PM
  • Added mobile behaviour to crads
fabianr retitled this revision from [WIP] Initial content for card to Initial content for card.Jul 4 2018, 4:02 PM
mart added inline comments.Jul 16 2018, 12:21 PM
source/components/card.rst
25 ↗(On Diff #37151)

what does this line mean?

52 ↗(On Diff #37151)

number of columns?

59 ↗(On Diff #37151)

how the component works right now is to support one basic layout:
image on top, then text, then optional action buttons.

some custom content can be put inside/in place of the text, and stuff can be stuffed in the top image as well

for other different kind of content there is the "empty" card which is just the white rectangle with shadow, which then becomes completely the app's responsibility on what layout to use in it

fabianr updated this revision to Diff 37926.Jul 17 2018, 6:23 AM
  • Changed advice for when to use a grid instead. Added an advice not to use too many cards
fabianr updated this revision to Diff 37927.Jul 17 2018, 6:29 AM
fabianr marked an inline comment as done.
  • Removed dupplicate content
fabianr added inline comments.Jul 17 2018, 6:32 AM
source/components/card.rst
25 ↗(On Diff #37151)

Changed the suggestion to be more clear.

fabianr added inline comments.Jul 18 2018, 3:45 PM
source/components/card.rst
59 ↗(On Diff #37151)

I would add a implementation section in another patch, and give hints for devs about the existing layouts there.

fabianr updated this revision to Diff 38092.Jul 19 2018, 1:37 PM
  • merged master, card page got moved to components/edit
  • Added changed index page of edit subsection of controls
mart added inline comments.Jul 23 2018, 12:03 PM
source/components/editing/card.rst
61

I would like to recomend instead to use the standard layout, the one that has a component (image on top, then text, then action buttons) and exampes where something completely custom would be used instead

Great HIG!
Only one suggested rephrasing and one small typo fix (see inline comments).

source/components/editing/card.rst
67

"Use a lot" sounds a bit too strong (I don't think we want people to overload their cards with visual fluff just because the HIG said so)
Suggested rephrasing:

Use images, icons or video elements to create visually immersive cards.

70

ration -> ratio

fabianr updated this revision to Diff 38243.Jul 23 2018, 12:11 PM
  • Rephrased content about visual immensive cards. Fixed typo
fabianr marked 2 inline comments as done.Jul 23 2018, 12:12 PM
fabianr updated this revision to Diff 38597.Jul 27 2018, 1:13 PM
  • Added recommendation to use default card layout
fabianr marked an inline comment as done.Jul 27 2018, 1:14 PM
mart accepted this revision as: mart.Jul 30 2018, 8:22 AM
This revision is now accepted and ready to land.Jul 30 2018, 8:22 AM
fabianr closed this revision.Jul 30 2018, 8:26 AM