Differential D13334

When using a different background color, use highlightedText as text color
ClosedPublic
Actions

Authored by apol on Jun 4 2018, 2:44 PM.

Details

Reviewers
mart
ngraham
Group Reviewers
Kirigami
Commits
R169:048da9adcbb9: When using a different background color, use highlightedText as text color
Summary

Make sure we are using a color designed to contrast with a background color.

Test Plan

Looks better on breeze, breeze dark and obsidian

Diff Detail

Repository
R169 Kirigami
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
apol created this revision.Jun 4 2018, 2:44 PM
Restricted Application added a project: Kirigami. · View Herald TranscriptJun 4 2018, 2:44 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
apol requested review of this revision.Jun 4 2018, 2:44 PM
apol updated this revision to Diff 35531.Jun 4 2018, 2:49 PM

Use better logic

ngraham accepted this revision.Jun 4 2018, 2:58 PM
ngraham added a subscriber: ngraham.

Awesome, much better!

This revision is now accepted and ready to land.Jun 4 2018, 2:58 PM
abetts added a subscriber: abetts.Jun 4 2018, 4:33 PM

Looks great! I don't have any suggestions.

apol updated this revision to Diff 35576.Jun 5 2018, 12:10 AM

Don't set the color if it's transparent

Closed by commit R169:048da9adcbb9: When using a different background color, use highlightedText as text color (authored by apol). · Explain WhyJun 5 2018, 10:43 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 35531

View Options

src/controls/private/PrivateActionToolButton.qml

Loading...