When using a different background color, use highlightedText as text color
ClosedPublic

Authored by apol on Mon, Jun 4, 2:44 PM.

Details

Summary

Make sure we are using a color designed to contrast with a background color.

Test Plan

Looks better on breeze, breeze dark and obsidian

Diff Detail

Repository
R169 Kirigami
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
apol created this revision.Mon, Jun 4, 2:44 PM
Restricted Application added a project: Kirigami. · View Herald TranscriptMon, Jun 4, 2:44 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
apol requested review of this revision.Mon, Jun 4, 2:44 PM
apol updated this revision to Diff 35531.Mon, Jun 4, 2:49 PM

Use better logic

ngraham accepted this revision.Mon, Jun 4, 2:58 PM
ngraham added a subscriber: ngraham.

Awesome, much better!

This revision is now accepted and ready to land.Mon, Jun 4, 2:58 PM
abetts added a subscriber: abetts.Mon, Jun 4, 4:33 PM

Looks great! I don't have any suggestions.

apol updated this revision to Diff 35576.Tue, Jun 5, 12:10 AM

Don't set the color if it's transparent

This revision was automatically updated to reflect the committed changes.