This commit fixes all fields which may have field separators like
payee, acccount, category, memo, number and money related fields.
As goodie the commit also handle double quotes inside memos.
Note: The previous implementation removes single quotes from memo fields,
which is now obsolate and may be reverted.
BUG:395025
FIXED-IN:4.8.3
compiled and exported to csv on linux
| Automatic diff as part of commit; lint not applicable. |
| Automatic diff as part of commit; unit tests not applicable. |
| kmymoney/plugins/csvexport/csvwriter.cpp | ||
|---|---|---|
| 448 | Since you enclose in double quotes later on, you might as well leave the \n as they are. | |
| 449 | m.replace(QLatin1Char('"'), QStringLiteral("\"\"")); | |
| 450 | I would write this as return QString("\"%1\"%2").arg(m, m_separator); | |
| 460 | You could make this a const auto txt = ... | |
| 461 | See format(QString) | |
| kmymoney/plugins/csvexport/csvwriter.cpp | ||
|---|---|---|
| 449 | QStringLiteral is Qt5 only, I added support for KDE4 and KF5 | |
| kmymoney/plugins/csvexport/csvwriter.cpp | ||
|---|---|---|
| 250 | it does, same for investment lines at line 310: strStatus += m_separator;. I will fix that before committing | |
| kmymoney/plugins/csvexport/csvwriter.cpp | ||
|---|---|---|
| 250 | That extra field separator was already in the old code. and will be fixed in an additional commit along with the mentioned investment column number issue. What we missed to see is that this commit adds an extra field separator in line 218, which I'm going to fix before committing. | |