Differential D13301

KMail: don't move the mainwindow to the current desktop when invoking a composer
ClosedPublic
Actions

Authored by dfaure on Jun 3 2018, 12:13 PM.

Details

Reviewers
dvratil
mlaurent
Commits
R206:7b5d2c0fc097: KMail: don't move the mainwindow to the current desktop when invoking a composer
Summary

Bringing up a composer or a viewer from the cmdline doesn't require
moving the mainwindow to the current desktop (which has annoyed me for a
long time).

This code assumes that kmail <any args> is always about bringing up a
composer or a viewer window; I didn't find another case in kmkernel's
handleCommandLine.

Test Plan

kmail faure@kde.org from another desktop.

Diff Detail

Repository
R206 KMail
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
dfaure requested review of this revision.Jun 3 2018, 12:13 PM
dfaure created this revision.
mlaurent accepted this revision.Jun 4 2018, 5:16 AM
This revision is now accepted and ready to land.Jun 4 2018, 5:16 AM
Closed by commit R206:7b5d2c0fc097: KMail: don't move the mainwindow to the current desktop when invoking a composer (authored by dfaure). · Explain WhyJun 13 2018, 8:57 AM
This revision was automatically updated to reflect the committed changes.
Restricted Application added a project: KDE PIM. · View Herald TranscriptJun 13 2018, 8:57 AM
Restricted Application edited subscribers, added: kde-pim; removed: KDE PIM. · View Herald Transcript
rikmills added a subscriber: rikmills.Jun 14 2018, 11:52 PM

Build failure:

https://build.neon.kde.org/job/bionic_stable_kde_kmail_bin_amd64/6/consoleFull

https://launchpadlibrarian.net/374424008/buildlog_ubuntu-bionic-amd64.kmail_4%3A18.04.1+p18.04+git20180614.0008-0_BUILDING.txt.gz

00:30:25 [ 96%] Building CXX object src/CMakeFiles/kmail.dir/main.cpp.o
00:30:25 src/CMakeFiles/kmail.dir/build.make:62: recipe for target 'src/CMakeFiles/kmail.dir/main.cpp.o' failed
00:30:25 /workspace/build/src/main.cpp:58:9: error: ‘int KMailApplication::newInstance(const QByteArray&, const QStringList&, const QString&)’ marked ‘override’, but does not override
00:30:25 int newInstance(const QByteArray &startupId, const QStringList &arguments, const QString &workingDirectory) override;
00:30:25 ^~~~~~~~~~~
00:30:25 make[4]: *** [src/CMakeFiles/kmail.dir/main.cpp.o] Error 1

mlaurent added a comment.Jun 15 2018, 5:05 AM

build kontactinterface first.
Regards

rikmills added a comment.Jun 15 2018, 5:51 AM
In D13301#278606, @mlaurent wrote:

build kontactinterface first.
Regards

Right. Thanks. Neon CI usually gets changes in deps built in the right order, so I didn't realise.

Revision Contents
Changeset List

PathPackages
Msrc/main.cpp (15 lines)

Diff 36083

View Options

src/main.cpp

Loading...