This patch causes the intended file name to be displayed in kioclient dir listings.
- Group Reviewers
Make sure your slave doesn't break with this patch applied.
Myself have not dealt with KIO/UDS for some years, so no clue what is wanted here. Also only touched this repo for buildsystem brush-over, so not a good reviewer candidate, thus resigning as reviewer.
@smithjd I would recommend to add some description of the motivation to the patch message, why is this change from UDS_NAME to UDS_DISPLAYNAME needed/wanted here. Does it fix a bug or imprive something?
As reviewers you might want to add the Plasma project, someone there might have a better clue about kioclient.
before-and-after screenshots from Dolphin would also help, as would a Bugzilla ticket or steps to reproduce, or anything else. Otherwise it's a bit hard to evaluate why this change is desirable.
In dolphin, you can click on "System Administration". With kioclient5, I can use kioclient5 ls settings:/system-administration (dito for dolphin). Does this still work after your change?
As you can see, as soon as you start to edit the URL, the UDS_NAME is used.
Probably something like
kioclient5 ls settings:/network
connectivity [Verbindungen] bluetooth [Bluetooth] networksettings [Einstellungen] kcm_networkmanagement [Verbindungen] .
"The file or folder System Administration does not exist."
This used to work for the Baloo tags:// ioslave, though it's less useful for that now that the slave no longer appends the full url to the filename. The working command was something like kioclient5 cp tags:/foo/. ~/bar. This successfully duplicated the tagged files and tag folder structure. I can't remember if I tested a single file, though if you needed a single file you probably wouldn't be digging in the tags:// ioslave anyway...
Oh, as you mention it, in future do not push to baloo without going through review - you have done this several times now, and while the changes may be ok, your commit messages are definitely subpar.