[kioclient] Use UDS_DISPLAY_NAME for file names.
AbandonedPublic

Authored by smithjd on Jun 2 2018, 9:25 PM.

Details

Reviewers
None
Group Reviewers
Plasma
Summary

This patch causes the intended file name to be displayed in kioclient dir listings.

Test Plan

Make sure your slave doesn't break with this patch applied.

Diff Detail

Repository
R126 KDE CLI Utilities
Branch
master-lsfix
Lint
No Linters Available
Unit
No Unit Test Coverage
smithjd created this revision.Jun 2 2018, 9:25 PM
Restricted Application added a project: Plasma. · View Herald TranscriptJun 2 2018, 9:25 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
smithjd requested review of this revision.Jun 2 2018, 9:25 PM
smithjd retitled this revision from Use UDS_DISPLAY_NAME for file names. to [kioclient] Use UDS_DISPLAY_NAME for file names..Jun 3 2018, 12:31 AM
kossebau resigned from this revision.Jun 10 2018, 5:24 PM

Myself have not dealt with KIO/UDS for some years, so no clue what is wanted here. Also only touched this repo for buildsystem brush-over, so not a good reviewer candidate, thus resigning as reviewer.

@smithjd I would recommend to add some description of the motivation to the patch message, why is this change from UDS_NAME to UDS_DISPLAYNAME needed/wanted here. Does it fix a bug or imprive something?

As reviewers you might want to add the Plasma project, someone there might have a better clue about kioclient.

smithjd edited the summary of this revision. (Show Details)Jun 11 2018, 1:23 AM
smithjd edited the test plan for this revision. (Show Details)
smithjd edited reviewers, added: Plasma; removed: kossebau.Jul 19 2018, 9:45 PM
smithjd added a subscriber: michaelh.
smithjd edited the summary of this revision. (Show Details)Aug 23 2018, 2:10 AM
bruns added a subscriber: bruns.Aug 23 2018, 1:31 PM

Can you please give an example?

  1. Exact command
  2. Current output
  3. Expected output

kioclient5 ls settings:/
system-administration

dolphin settings:/
System Administration

bruns added a comment.Aug 23 2018, 7:06 PM

kioclient5 ls settings:/
system-administration

dolphin settings:/
System Administration

That belongs into the test plan, of course with the needed context.

before-and-after screenshots from Dolphin would also help, as would a Bugzilla ticket or steps to reproduce, or anything else. Otherwise it's a bit hard to evaluate why this change is desirable.

bruns added a comment.Aug 23 2018, 7:09 PM

kioclient5 ls settings:/
system-administration

dolphin settings:/
System Administration

In dolphin, you can click on "System Administration". With kioclient5, I can use kioclient5 ls settings:/system-administration (dito for dolphin). Does this still work after your change?

bruns added a comment.Aug 23 2018, 7:32 PM

As you can see, as soon as you start to edit the URL, the UDS_NAME is used.

Probably something like
kioclient5 ls settings:/network

connectivity           [Verbindungen]
bluetooth              [Bluetooth]
networksettings        [Einstellungen]
kcm_networkmanagement  [Verbindungen]
.

kioclient5 ls settings:/
system-administration

dolphin settings:/
System Administration

In dolphin, you can click on "System Administration". With kioclient5, I can use kioclient5 ls settings:/system-administration (dito for dolphin). Does this still work after your change?

No.

"The file or folder System Administration does not exist."

This used to work for the Baloo tags:// ioslave, though it's less useful for that now that the slave no longer appends the full url to the filename. The working command was something like kioclient5 cp tags:/foo/. ~/bar. This successfully duplicated the tagged files and tag folder structure. I can't remember if I tested a single file, though if you needed a single file you probably wouldn't be digging in the tags:// ioslave anyway...

This used to work for the Baloo tags:// ioslave,

Oh, as you mention it, in future do not push to baloo without going through review - you have done this several times now, and while the changes may be ok, your commit messages are definitely subpar.

smithjd abandoned this revision.Aug 24 2018, 3:48 AM

Closing this because it breaks at least the settings:// ioslave, and the tags:// slave no longer has urls attached to the filename.